Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Skip creating partition rate limiters when not enable #38816

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

enhance: Skip creating partition rate limiters when not enable #38816

wants to merge 5 commits into from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Merged
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 27, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo December 27, 2024 09:17
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Open
40 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 27, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Dec 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (95c1ccc) to head (4d3958f).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38816       +/-   ##
===========================================
+ Coverage   69.45%   82.94%   +13.49%     
===========================================
  Files         294     1091      +797     
  Lines       26430   169638   +143208     
===========================================
+ Hits        18357   140707   +122350     
- Misses       8073    23339    +15266     
- Partials        0     5592     +5592
Components Coverage Δ
Client 79.12% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.09% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/quota_center.go 82.44% <100.00%> (ø)

... and 1384 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@bigsheeper bigsheeper mentioned this pull request Jan 1, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

This was referenced Jan 1, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@yhmo yhmo Awaiting requested review from yhmo

Assignees
No one assigned
Labels
10kcp PR related to 10k collection partitions Project dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigsheeper @sre-ci-robot